On Fri, Jan 16, 2009 at 9:39 AM, Karen Tracey <kmtra...@gmail.com> wrote:
> On Fri, Jan 16, 2009 at 9:15 AM, Alex Gaynor <alex.gay...@gmail.com>wrote: > >> I'm seeing some failures exclusively under PgSQL: >> http://dpaste.com/109831/ . I'm not sure what's causing them, but it's >> just the admin views tests, no other ones. >> > > (PgSQL is PostgreSQL ... ?) > > I see those too, on my PostgreSQL test machine. But I saw them before the > test rollback changes as well. When I looked into them I concluded they > were related to #9006/#9758. They all involve attempts to update a page > with multiple inline-edited objects, and it seems the DB returns the objects > in a different order on the POST than it did when the form was originally > created on the GET, which results in the admin/form code failing to match up > the actual instances to the form data, resulting in redisplay of the form > with "Please correct the errors below" (and status code of 200) instead of > the expected redirect from a successful form post. > > For me, these were not introduced by the test rollback changes, they were > pre-existing problems that I haven't had time to look into much more closely > than what I've written above and in one of those tickets. Are you only > seeing these after r9756? > > Karen > > > > PgSQL is indeed PostgreSQL. Yes, I do still get the failures pre-fast tests, I guess I'd never run those tests. I would like to say that when I went back to test that the tests were unbearably slow, so that makes me super happy about the new fast tests, thanks for all your hard work. Alex -- "I disapprove of what you say, but I will defend to the death your right to say it." --Voltaire "The people's good is the highest law."--Cicero --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---