On Nov 18, 5:15 pm, Malcolm Tredinnick <[EMAIL PROTECTED]>
wrote:
> On Mon, 2008-11-17 at 16:19 -0800, Matthew D. Hancher wrote:
>
> [...]
>
> > Options include:
>
> > A. Leave sqlite3 as the default, and add a configuration setting that
> > forces use of pysqlite2 if desired.
>
> > B. Always try both sqlite3 and pysqlite2, and use whichever has the
> > greater version number if both are present.
>
> > C. Same as B, but with an optional configuration option to force one
> > or the other if desired.
>
> > D. Switch to making pysqlite2 the default, since that's the correct
> > name for the module if the user has explicitly installed it, and treat
> > the Python-bundled version as the fallback.
[...]
> I guess I prefer D the most, subject to a slight concern if the wrong
> version could possibly be imported (but I can't imagine how). Then
> option A. Don't like the others at all.
Well, I think it's actually not so implausible that option D could
cause
someone somewhere a problem. All it would take would be for them
to have an outdated version of pysqlite2 installed on their system.
Django would have been happily ignoring it since r3818, and suddenly
we'd be using it instead. Lord knows how many babies might be killed.
So, if you're not a fan of option B then I'm inclined to go with the
conservative option A. Then the question is, what should the
configuration option look like? Here are two options:
1: SQLITE_MODULE_NAME = 'pysqlite2'
2: DATABASE_OPTIONS = {'module': 'pysqlite2'}
3: USE_PYSQLITE2 = True
4: # Other
Preferences? My current vote is option 2, because it does not
introduce a new top-level setting, but it does sort of overload an
existing one, so I'd understand arguments in favor of option 1.
Matt
Matt Hancher
Intelligent Systems Division
NASA Ames Research Center
[EMAIL PROTECTED]
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---
