On Mon, 2008-08-18 at 12:04 -0700, Matt Boersma wrote: > This is just a heads up since clearly some committers must be unaware: > checkins of the last two days have created 27 (yes, twenty-seven) new > test case failures for Oracle. I had been working on cleaning up the > existing few failures for the Oracle backend, but unless those who > actually committed the weekend's changes are able to look at this, > Oracle should not be included in the 1.0 release IMHO.
I'm always happy to look at problems, but some specific details are required, for the reasons described below. > I realize running all the backends (and all three pythons) to check > for regression failures before committing code is onerous. No, it's actually impossible, not merely difficult. I simply don't have the disk space or the CPU resources to run Oracle on my laptop. My recollection is that even when I had access to a 64-bit 2 GHz desktop machine, it still took over an hour to run all the tests even if I did nothing else on the machine. Leo's buildbot has only been available for a few days now and I did actually try to check it a couple of times over the weekend and it timed out on a number of ocassions (I managed to get through just now, but it took a while). To utilise a buildbot we do have to commit first, obviously. > However, > that's what I do, and now I'm reminded why. It's not enough to see > that the code runs on sqlite or postgres and call it a day. However, we do rely a lot on the Oracle backend maintainers to also help us out here. That's why commit messages often include quite a bit of detail. I'm obviously responsible for a number of the internal changes and whilst I try very, very hard not to break stuff and be clear about what's going, sometimes breakages happen. Some of the differences are because Oracle does do some extra query munging, so it sometimes takes a day or two until it becomes clear that breakages are happening. Leo's buildbot has only just become available and is a bit slow to respond to requests (i.e. timed out over the weekend). Every resource is obviously a benefit here, but we do have to commit before we can see failures. So, I definitely apologise for any inadvertent hardship caused here. I fully appreciate that we're all volunteers. If you could work with us on this as the backend maintainer there, it would be helpful. I'm obviously not intending to break the Oracle build, but I'm also not in a position to do more than document cleanly what's going, try to be pre-emptively careful and answer questions about specific quickly. Perhaps some actual specific questions instead of mail titled "You've broken Oracle" would be more useful to all of us. I'm quite happy to explain the motivation and necessities behind a bunch of the changes and work out better ways to do things once I know what the problem is ("it's broken" and even "the tests fail" is not a problem report; neither includes enough information to debug the root cause). I can probably guess, for example, that the select_related failures are due to r8426, but I can't be sure without more information. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---