On Sat, Jul 19, 2008 at 1:58 PM, Jason Yan <[EMAIL PROTECTED]> wrote:
>
> Re: http://code.djangoproject.com/ticket/7611
>
> The current situation is that if you create a new Django project and
> run the unit tests, the contrib.auth baisc tests fail due to missing
> templates.  These templates are provided by the admin app, which is
> not installed by default.  Russell brought up some points which made
> me think about this more.  My initial implementation was to force the
> inclusion of the admin app if it wasn't already installed, but I agree
> with Russell's initial comment that it isn't testing for the presence
> of the admin app.
>
> I believe that we should not run these tests if we cannot find the
> templates for the same reason we don't run Docutils tests if docutils
> is not installed.  Though the error reported that the template is not
> found is "correct", I don't believe it is a correct test failure
> because that is not the goal of the test case.

I disagree. Like I say in the comment for the ticket, you can't claim
that the auth application works correctly in your project if those
templates are not available.

The comparison with docutils tests is slightly off target. There is an
argument to me made for skipping those tests - but not because we
can't find the templates. Failing due to the non-existence of the
templates is a legitimate failure if the user is actually using the
views.

However, if the user is _not_ using the views (e.g., they're using the
auth.User model, but providing their own login views), there is an
argument to be made for skipping the tests.

There could actually be an overlap here with #4788 - that ticket calls
for a mechanism to skip and report tests that are known and acceptable
failures. Providing a project-level way to skip tests that are known
failures could be one solution to both problems.

Yours
Russ Magee %-)

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to