On 9/13/06, Michael Radziej <[EMAIL PROTECTED]> wrote: > > Russell Keith-Magee wrote: > > Submitting a patch without tests is almost _exactly_ the _worst_ thing > > you can do if you want your patch to be committed. > > When I submit a patch, I'd really like to see some serious > interest from the committers before I go through the loops and > create test cases, documentation and polish everything up nicely,
My point is that test cases and documentation shouldn't be regarded as a post facto activity; they are a core part of develoment itself. If you're going to devote time to working on a problem, you should work on the whole problem, not just the fun part. However, that said, I agree that nobody wants to waste effort on a patch+tests+docs that will be discarded or ignored - so the problem becomes 'how do we indicate on the ticket system that a patch is required?' I agree that this is an area where the ticket system needs clarification, and the triage team could be a lot of help. > I really could not see any connection between patch quality (== > test cases, docs, follows style) and how fast it was handled. Obviously, simple changes are no brainers. However, if a patch is a deep change, I (as a developer) need to be convinced: 1) That the problem actually exists 2) That the proposed fix is the right approach to solve the problem (e.g., there are lots of patches for Manipulators at the moment - but the right fix is to get rid of them altogether) 3) That the proposed fix is correct Submitting a big, deep patch (even if it is tested) is a very small part of this - the dialog that surrounds the patch is equally important. This means a clear statement of the problem in the ticket itself, and evidence of some discussion of alternatives that has engaged the committers. Again, this is an area where a triage team could be a lot of help - checking big patches, kick-starting discussion for tickets that are worthy of deeper examination, etc. Yours, Russ Magee %-) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers -~----------~----~----~----~------~----~------~--~---
