[EMAIL PROTECTED] wrote: > http://code.djangoproject.com/attachment/ticket/2070/3581-streaming_uploads_and_uploadprogress_middleware_code_cleanup_review.diff
One thing I disagree with is that streaming on disk is done unconditionally. This is very good for files the size of tens of megabytes but for many small files this would be sometimes slower than keeping them in memory. My original patch used a boolean setting STORE_UPLOAD_ON_DISK to switch it on or off. However now I think it would be better to set a maximum size of upload file that can be stored in memory and store on disk only larger files. And also this same setting should be used for buffer size instead of now hard-coded 64000. P.S. I'm know as an inventor of very poor settings names but I would propose something like UPLOAD_BUFFER_SIZE. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers -~----------~----~----~----~------~----~------~--~---
