Hi Robert,
On 12/13/05, Robert Wittams <[EMAIL PROTECTED]> wrote:
> http://code.djangoproject.com/wiki/DescriptorFields
I like the thoughts behind the changes, it seems to make it more
consistent and compact, however what confused me was:
p1.article_set.order_by('headline')
One could read this as setting order by for p1.article. It is
unclear, to my reading, what this would accomplish. There's no
correlation to the fact that you are retrieving data with
p1.article_set, which is what get_article_list did convey.
This is especially interesting given:
reporter.article_set
reporter.article_set.filter(headline__startswith='This').order_by('headline')
reporter.article_set.add(headline="John's second story",
pub_date=datetime(2005, 7, 29))
Where you added explicit functions for filter() and add(), but getting
the complete list is made implicit in article_set. Wouldn't this kind
of go against the philosophy of Django?
Other than that I like the proposal.
Hope this is some commentary that will help you.
--
Jeroen Ruigrok van der Werven <asmodai(-at-)in-nomine.org> / asmodai
Free Tibet! http://www.savetibet.org/ | Je maintiendrai!
http://www.in-nomine.org/ | [EMAIL PROTECTED]
Into each life some rain must fall, some days must be dark and dreary...
