Adrian Holovaty wrote: > Thoughts? > > http://code.djangoproject.com/wiki/RemovingTheMagic > > Please comment here rather than on the wiki. > > Adrian > > -- > Adrian Holovaty > holovaty.com | djangoproject.com | chicagocrime.org >
This does all seem sensible to me so far. Couple of points: * Not entirely sure about the whole manager/objects thing. How about the metaclass or import hook just looks through all of the existing attributes of the field. If there is a manager already, it leaves that one there (assigning something to it so it knows what it is a manager of) , other than that it makes one called 'objects'. This way it doesn't need to go into META. * The Person.q thing is a bit odd. I currently just don't know what should be done for queries in the end - oh, for real macros. However, as this suggestion doesn't offer "more power" than the current system, it would seem to just be another api to worry about breaking.