Hello Tim, Sorry for trouble. Following Django practices, we've started to only do *one* commit per PR which means that we no longer have a change with commits that work and others that don't. The big "Bumped version to 3.4.0rc1" commit contains release *only* changes like PO file changes from Transifex, compilemessages, etc.. it's why it shows as 5k lines +.
Regarding the ImportError cannot import name 'has_page_change_permission' error, this is caused by our refactor of the permissions logic. has_page_change_permission was not a public API and as such got removed without a deprecation period, you can see the list of functions that were removed in the release notes <http://docs.django-cms.org/en/latest/upgrade/3.4.html#permissions>. Most of the functions there were replaced by more specific functions in cms.utils.page_permissions, if you still rely on the CMS permissions system feel free to ping me to get more information on the new API. Like the old one, it's still private but now it's very unlikely to change for a bit. On Thursday, September 1, 2016 at 9:41:08 PM UTC-4, Tim Graham wrote: > > Hi, > > I wanted to share my experience trying to update to django-cms 3.4. When I > launch my app, I get a NoReverseMatch exception related to URL reversing, > so I tried to use git bisect to find the commit where the behavior changed > in the django-cms. This wasn't so pleasant as there were a long string of > commits where I couldn't run my app due to "ImportError cannot import name > 'has_page_change_permission'" coming from django-cms. It seems that > django-cms may be broken in its history for quite a few commits (maybe > during the massive "Bumped version to 3.4.0rc1" merge commit?) which makes > it quite difficult to pin exactly why my app is failing. I'm not sure if > this is a common issue anyone else has seen or if it could have been > avoided, but I just wanted to emphasize that it's really helpful if > django-cms is working after each commit to help in a case like this. I'll > admit that I don't really understand how git merging works but I find > Django's cherry picking of commits to make backports to be very reliable in > terms of making history bisectable. Anyway, just wanted to share in case > some process improvement could come of it. I'll try to debug the actual > problem with my app later. > > > There are only skipped commits left to test. > The first bad commit could be any of: > 035de0310f54ed4b2ddacf9bd715c3ab4e9de072 > 046dc3e937b18a4f16526257320aa25a7a143754 > 1c92e02c8bfaba544663c91c6d7efa30e40e0de0 > 70a5c61500d7d3c7f09f7844bb64db4beeff7a7c > 4989c294bc21dd725690983a0034300d5c1770e5 > f96c80357c7152ef46045842ad0edb9b27dddae7 > 0136232ded0b97605d88df3da0f42a7fa13fcda5 > bc1ae40a84592436ef56ac93a21e3f5320324174 > 59d303bb0b07beecbbe3f18a2498e382d6022430 > 8e2e049eaaf85b01a1e1949ce6dec6366fca577e > 153b3d5625117769354918fb28ae73c48b417a4d > c6e7ccd9c1e8fab5bc257abb6d9e6b268fb93f9a > c7617f3150e3fddc37ed2345aa2d38b6f0956ee1 > 365e503f7e21e924cfae13bf7a0f8364b2e98d4c > db2b69ba800033515aa8cdf907895cb7d7fb19be > aabeb755ee6d711f403370f1b4149b3de2e985fc > 355b7671b60a43b53f60ff3f23be57f460e920b2 > 4fd0d66ecdc44fa081b1d19e8550320a00b59b76 > a4c0cb5d99bee250b6f0c6e33f50503a8248ef7c > d41b42316ebacb236ca116a4b2aa324291da673e > e686f74542b08757a8c996df034909d158573780 > 08c51d30a00727fae9c47ba650cb088e7646f47b > 9b4af053b1f3d90e52d4c054b83682aef05c57d2 > af21e0c352df6a07d98587c1e8a31f072a6a43e8 > 16e3bbecb7c9bf5d77c56e49832f473b177de6cf > 5c09f1d731aa644fb091941654a37843ff9eab7a > b4ca4580aaa7531644ccc6661614d21417d3ee7b > We cannot bisect more! > > -- Message URL: https://groups.google.com/d/msg/django-cms-developers/topic-id/message-id Unsubscribe: send a message to [email protected] --- You received this message because you are subscribed to the Google Groups "django CMS developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/django-cms-developers/2b224bd0-a333-42be-b7b2-ae9110139a4a%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
