tqchen commented on PR #717: URL: https://github.com/apache/tvm-ffi/pull/717#issuecomment-5464158070
I know it is a debatable decision, i still think it is helpful for subclass to explicitly registers the attributes into the table at the ABI level. Whereas the TypeAttr serves as an attr table without boiling down into subclass decision. Subclass do not necessarily mean the carry over of semantics especially in presence of new fields. Doing so would simplify the code size and handling here. One trick that can perserve the same behavior, while being more efficient in the backend, is to be able auto re-register key parent functions in py_class initialization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
