gemini-code-assist[bot] commented on PR #18658: URL: https://github.com/apache/tvm/pull/18658#issuecomment-3737491054
## Summary of Changes Hello @locnd182644, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the ONNX frontend's capability to handle the PReLu operator by introducing robust logic for interpreting and processing various `slope` tensor shapes. The changes ensure that the `axis` argument is correctly inferred and the `slope` is appropriately reshaped, aligning with ONNX broadcasting rules. This enhancement prevents errors and increases the compatibility of Relax with ONNX models that utilize diverse PReLu configurations, ultimately making the frontend more flexible and reliable. ### Highlights * **Enhanced PReLu Operator Handling**: The ONNX frontend now supports a wider variety of `slope` tensor shapes for the PReLu operator, including `(1xCx1x1)`, `(S,)`, and `(1,1)`, ensuring correct interpretation and application of the slope argument. * **Dynamic Axis Determination**: Introduced logic within the `PRelu` converter to dynamically determine the correct `axis` argument for the `relax.op.nn.prelu` function based on the input `x` shape and the `slope` tensor's dimensions. * **Robust Slope Reshaping**: Implemented conditional reshaping of the `slope` tensor to a 1D array before passing it to the `relax.op.nn.prelu` function, accommodating different broadcasting patterns defined by ONNX. * **Improved `topi.nn.elemwise.prelu`**: Modified the `prelu` function in `tvm.topi.nn.elemwise` to conditionally broadcast the slope only when its first dimension is 1, optimizing behavior for already correctly shaped slopes. * **Expanded Test Coverage**: Added new test cases for the `PRelu` operator in `test_frontend_onnx.py` to validate the correct handling of the newly supported `slope` shapes, ensuring robustness and preventing regressions. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
