tqchen commented on PR #379: URL: https://github.com/apache/tvm-ffi/pull/379#issuecomment-3724513729
Thanks for the contribution. For this particular case, i feel we should defer a bit, since structural equalty is already supported through explicitly. While classes like list do not necessarily support nested comparison directly via operators. For immutable objects there is some merits for having the feature. This is mainly a consideration of minimalism and also consistency with wrt to instances like c++. As a middle ground, perhaps let us first document structural_equal and structural_hash APIs and refer users to them. Personally i think keeping it simple here might better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
