gemini-code-assist[bot] commented on code in PR #370:
URL: https://github.com/apache/tvm-ffi/pull/370#discussion_r2650867714
##########
tests/cpp/test_any.cc:
##########
@@ -58,6 +58,20 @@ TEST(Any, Int) {
view0 = v1;
EXPECT_EQ(view0.CopyToTVMFFIAny().type_index, TypeIndex::kTVMFFIInt);
EXPECT_EQ(view0.CopyToTVMFFIAny().v_int64, 2);
+
+ uint64_t v2 = static_cast<uint64_t>(std::numeric_limits<int64_t>::max()) + 1;
Review Comment:
For portability, it's best to include the `<limits>` header directly, as
`std::numeric_limits` is defined there. While this might compile on some
platforms due to transitive includes (e.g., from `gtest/gtest.h`), it's not
guaranteed to work on all platforms and compilers. Explicitly including headers
for the symbols used is a good practice for maintainability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
