gemini-code-assist[bot] commented on PR #360: URL: https://github.com/apache/tvm-ffi/pull/360#issuecomment-3685455395
Thank you for the follow-up question, @junrushao. The `target_link_libraries` calls introduced in this pull request (lines 127, 128, 131, and 132) correctly address the linking issues for `pthread` and `dl` as described in the PR description. However, my review is strictly limited to the changes presented in this pull request. Therefore, I cannot perform a comprehensive check of the entire `CMakeLists.txt` file for other potential misuses of `target_link_libraries` that are outside the scope of these specific modifications. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
