tqchen commented on PR #348: URL: https://github.com/apache/tvm-ffi/pull/348#issuecomment-3683678460
Thanks a lot for contributions, i maybe a bit off recently but should be able to come back and take closer look around Jan. would be good to also get some eyes for rust reviews. cc @DarkSharpness @Ubospica if u have bandwidth Some high-level feedbacks: - Likely we can use Index overload, so we can do array[i] - Avoid doing the object-type-index generic conversion in get(or index), since sometimes T can be backed by both special and Object, instead use AnyCompatible trait, which is meant to define conversion rule of T from/to any - Keep array immutable for now, as of now we are still discussing mutable handling, so let us keep array immutable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
