junrushao commented on code in PR #354:
URL: https://github.com/apache/tvm-ffi/pull/354#discussion_r2638607647
##########
cmake/Utils/Library.cmake:
##########
@@ -257,24 +258,24 @@ function (tvm_ffi_configure_target target)
# LINK_HEADER
if (tvm_ffi_arg__LINK_HEADER)
- if (TARGET tvm_ffi_header)
- target_link_libraries("${target}" PRIVATE tvm_ffi_header)
+ if (TARGET tvm_ffi::header)
+ target_link_libraries("${target}" PRIVATE tvm_ffi::header)
else ()
message(
FATAL_ERROR
- "tvm_ffi_configure_target(${target}): LINK_HEADER requested but
target 'tvm_ffi_header' does not exist."
+ "tvm_ffi_configure_target(${target}): LINK_HEADER requested but
targets 'tvm_ffi::header' do not exist."
)
endif ()
endif ()
# LINK_SHARED
if (tvm_ffi_arg__LINK_SHARED)
- if (TARGET tvm_ffi_shared)
- target_link_libraries("${target}" PRIVATE tvm_ffi_shared)
+ if (TARGET tvm_ffi::shared)
+ target_link_libraries("${target}" PRIVATE tvm_ffi::shared)
else ()
message(
FATAL_ERROR
- "tvm_ffi_configure_target(${target}): LINK_SHARED requested but
target 'tvm_ffi_shared' does not exist."
+ "tvm_ffi_configure_target(${target}): LINK_SHARED requested but
targets 'tvm_ffi::shared' do not exist."
)
endif ()
endif ()
Review Comment:
I don't think we need backward compatibility here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
