gemini-code-assist[bot] commented on code in PR #352: URL: https://github.com/apache/tvm-ffi/pull/352#discussion_r2637263797
########## README.md: ########## @@ -17,15 +17,15 @@ # TVM FFI: Open ABI and FFI for Machine Learning Systems -📚 [Documentation](https://tvm.apache.org/ffi/) | 🚀 [Quickstart](https://tvm.apache.org/ffi/get_started/quickstart.html) +📚 [Documentation](https://tvm.apache.org/ffi/) Apache TVM FFI is an open ABI and FFI for machine learning systems. It is a minimal, framework-agnostic, yet flexible open convention with the following systems in mind: -- **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. -- **Kernel DSLs** - reusable open ABI for JIT and AOT kernel exposure frameworks and runtimes. +- **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. [[FlashInfer](https://docs.flashinfer.ai/)] Review Comment:  The Markdown syntax for the link to FlashInfer is incorrect. It uses double square brackets `[[...]]` which will not render as a link. Please use the standard `[text](url)` format. ```suggestion - **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. [FlashInfer](https://docs.flashinfer.ai/) ``` ########## README.md: ########## @@ -17,15 +17,15 @@ # TVM FFI: Open ABI and FFI for Machine Learning Systems -📚 [Documentation](https://tvm.apache.org/ffi/) | 🚀 [Quickstart](https://tvm.apache.org/ffi/get_started/quickstart.html) +📚 [Documentation](https://tvm.apache.org/ffi/) Apache TVM FFI is an open ABI and FFI for machine learning systems. It is a minimal, framework-agnostic, yet flexible open convention with the following systems in mind: -- **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. -- **Kernel DSLs** - reusable open ABI for JIT and AOT kernel exposure frameworks and runtimes. +- **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. [[FlashInfer](https://docs.flashinfer.ai/)] +- **Kernel DSLs** - reusable open ABI for JIT and AOT kernel exposure frameworks and runtimes. [[TileLang](https://tilelang.com/)][[cuteDSL](https://docs.nvidia.com/cutlass/latest/media/docs/pythonDSL/cute_dsl_general/compile_with_tvm_ffi.html)] - **Frameworks and runtimes** - a uniform extension point for ABI-compliant libraries and DSLs. -- **ML infrastructure** - out-of-the-box bindings and interop for Python, C++, and Rust. +- **ML infrastructure** - out-of-the-box bindings and interop for [Python](https://tvm.apache.org/ffi/get_started/quickstart.html#python), [C++](https://tvm.apache.org/ffi/get_started/quickstart.html#c-), and [Rust](https://tvm.apache.org/ffi/get_started/quickstart.html#rust). Review Comment:  The URL anchor for C++ (`#c-`) seems incorrect and will likely result in a broken link. The `quickstart.rst` file defines an explicit label `cpp_load` for the C++ section, so the anchor in the generated HTML will likely be `cpp_load`. Please update the link to use the correct anchor. ```suggestion - **ML infrastructure** - out-of-the-box bindings and interop for [Python](https://tvm.apache.org/ffi/get_started/quickstart.html#python), [C++](https://tvm.apache.org/ffi/get_started/quickstart.html#cpp_load), and [Rust](https://tvm.apache.org/ffi/get_started/quickstart.html#rust). ``` ########## README.md: ########## @@ -17,15 +17,15 @@ # TVM FFI: Open ABI and FFI for Machine Learning Systems -📚 [Documentation](https://tvm.apache.org/ffi/) | 🚀 [Quickstart](https://tvm.apache.org/ffi/get_started/quickstart.html) +📚 [Documentation](https://tvm.apache.org/ffi/) Apache TVM FFI is an open ABI and FFI for machine learning systems. It is a minimal, framework-agnostic, yet flexible open convention with the following systems in mind: -- **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. -- **Kernel DSLs** - reusable open ABI for JIT and AOT kernel exposure frameworks and runtimes. +- **Kernel libraries** - ship one wheel to support multiple frameworks, Python versions, and different languages. [[FlashInfer](https://docs.flashinfer.ai/)] +- **Kernel DSLs** - reusable open ABI for JIT and AOT kernel exposure frameworks and runtimes. [[TileLang](https://tilelang.com/)][[cuteDSL](https://docs.nvidia.com/cutlass/latest/media/docs/pythonDSL/cute_dsl_general/compile_with_tvm_ffi.html)] Review Comment:  The Markdown syntax for the links to TileLang and cuteDSL is incorrect. It uses double square brackets `[[...]]` which will not render as links. Also, there should be a separator (like a comma and a space) between the two links for better readability. Please use the standard `[text](url)` format for links. ```suggestion - **Kernel DSLs** - reusable open ABI for JIT and AOT kernel exposure frameworks and runtimes. [TileLang](https://tilelang.com/), [cuteDSL](https://docs.nvidia.com/cutlass/latest/media/docs/pythonDSL/cute_dsl_general/compile_with_tvm_ffi.html) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
