tqchen commented on code in PR #334:
URL: https://github.com/apache/tvm-ffi/pull/334#discussion_r2612535541
##########
src/ffi/extra/module.cc:
##########
@@ -30,6 +31,31 @@
namespace tvm {
namespace ffi {
+/*!
+ * \brief Global modules, i.e. modules that are owned by the runtime and
should not be unloaded.
+ * On the frontend, a module is added to the registry if `keep_alive=True`
when `load_module` is
+ * called.
+ */
+struct ModuleGlobals {
+ std::unordered_set<Module, ObjectPtrHash, ObjectPtrEqual> modules;
+ std::mutex mutex;
+
+ void Add(const Module& m) {
+ std::scoped_lock<std::mutex> lock(mutex);
+ modules.insert(m);
+ }
+
+ void Remove(const Module& m) {
+ std::scoped_lock<std::mutex> lock(mutex);
+ modules.erase(m);
+ }
+
+ static ModuleGlobals& Get() {
Review Comment:
ModuleGlobals* Global()
##########
src/ffi/extra/module.cc:
##########
@@ -30,6 +31,31 @@
namespace tvm {
namespace ffi {
+/*!
+ * \brief Global modules, i.e. modules that are owned by the runtime and
should not be unloaded.
+ * On the frontend, a module is added to the registry if `keep_alive=True`
when `load_module` is
+ * called.
+ */
+struct ModuleGlobals {
+ std::unordered_set<Module, ObjectPtrHash, ObjectPtrEqual> modules;
Review Comment:
keep these fields as private members
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
