tqchen commented on code in PR #330:
URL: https://github.com/apache/tvm-ffi/pull/330#discussion_r2611013207
##########
python/tvm_ffi/utils/_build_optional_torch_c_dlpack.py:
##########
@@ -543,7 +543,13 @@
.dtype(at::toScalarType(prototype->dtype))
.device(at::getATenDeviceForDLPackv1(prototype->device.device_type,
prototype->device.device_id));
- at::Tensor tensor = at::empty(shape, options);
+ at::Tensor tensor;
Review Comment:
likely we shouldnot do this, and instead try to have a layer on top of
FromEnvAlloc that adds strides
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
