junrushao commented on issue #326: URL: https://github.com/apache/tvm-ffi/issues/326#issuecomment-3639111161
Indeed this is a good idea! BTW, do you foresee any further perf optimization opportunities even in the code snippet you share? e.g. it looks up twice - can we make it look up only once? > ``` > def get(self, key: K, default: V | _DefaultT | None = None) -> V | _DefaultT | None: > return self[key] if key in self else default > ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
