gemini-code-assist[bot] commented on PR #18548: URL: https://github.com/apache/tvm/pull/18548#issuecomment-3617040392
## Summary of Changes Hello @guan404ming, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the PyTorch FX frontend for Relax by introducing flexible support for the NHWC image layout in interpolation operations. Previously, the `interpolate` operation was rigidly tied to the NCHW layout, which limited its adaptability. By allowing users to specify their preferred image layout, this change improves compatibility with various target platforms and optimizes performance for models that benefit from NHWC data arrangements. ### Highlights * **NHWC Layout Support**: The `TorchFXImporter` class now supports specifying the default image layout (NCHW or NHWC) during initialization, addressing the previous hardcoding to NCHW for interpolation operations. * **Dynamic Spatial Dimension Calculation**: The `_interpolate` method within `TorchFXImporter` has been updated to dynamically determine spatial dimensions based on the configured `default_image_layout`, ensuring correct behavior for both NCHW and NHWC inputs. * **Public API Exposure**: The public `from_fx` function now exposes a `default_image_layout` parameter, allowing users to explicitly choose the image layout when importing PyTorch FX graphs, enhancing user flexibility. * **Comprehensive Testing**: New unit tests have been added to validate the correct behavior of `interpolate` with both NCHW (default) and NHWC layouts, covering nearest neighbor and bilinear interpolation modes, and ensuring backward compatibility. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
