junrushao commented on code in PR #286: URL: https://github.com/apache/tvm-ffi/pull/286#discussion_r2566742039
########## include/tvm/ffi/function.h: ########## @@ -33,15 +33,20 @@ #define TVM_FFI_DLL_EXPORT_INCLUDE_METADATA 0 #endif +#if TVM_FFI_DLL_EXPORT_INCLUDE_METADATA Review Comment: I suppose it's fine to wildcard include `sstream`? ########## include/tvm/ffi/function.h: ########## @@ -33,15 +33,20 @@ #define TVM_FFI_DLL_EXPORT_INCLUDE_METADATA 0 #endif +#if TVM_FFI_DLL_EXPORT_INCLUDE_METADATA Review Comment: I suppose it's fine to wildcard include `sstream` without the guards? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
