yaoyaoding commented on code in PR #230:
URL: https://github.com/apache/tvm-ffi/pull/230#discussion_r2539774222
##########
python/tvm_ffi/cpp/extension.py:
##########
@@ -40,7 +40,7 @@ def _hash_sources(
cuda_source: str | None,
cpp_files: Sequence[str] | None,
cuda_files: Sequence[str] | None,
- functions: Sequence[str] | Mapping[str, str],
+ functions: Sequence[str] | Mapping[str, str | None],
Review Comment:
If we allow `None` here, it seems allow the user to only provide docstring
for some functions while leave docs for other function be None.
But I feel it's not very necessary here, the user can use empty string as a
placeholder for the functions do not need a docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
