tqchen commented on issue #264: URL: https://github.com/apache/tvm-ffi/issues/264#issuecomment-3543937193
It depends on how the tvm-ffi is being used. aka the same issue can occur in std::shared_ptr with custom deleter, in most c++ applications, since scenario of L2 is less common. Most ops uses destinatin passing and do not allocate memory, so places like our quick start guide do not rely on it. `TVMFFIEnvTensorAlloc` by its name is tied to environment so like @yaoyaoding suggested, if a C++ applications calls a kernel that uses `TVMFFIEnvTensorAlloc`, the c++ application needs to first set that allocator. Perhaps what we can do in that case is provide a reasonable default for users to set which can be implemented by FromNDAlloc(since it is safe in such case to do so). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
