DarkSharpness commented on code in PR #218:
URL: https://github.com/apache/tvm-ffi/pull/218#discussion_r2485866103
##########
include/tvm/ffi/container/container_details.h:
##########
@@ -175,9 +175,9 @@ template <typename Converter, typename TIter>
class IterAdapter {
public:
using difference_type = typename
std::iterator_traits<TIter>::difference_type;
- using value_type = typename Converter::ResultType;
- using pointer = typename Converter::ResultType*;
- using reference = typename Converter::ResultType&;
+ using value_type = const typename Converter::ResultType;
+ using pointer = const typename Converter::ResultType*;
+ using reference = const typename Converter::ResultType;
Review Comment:
correct. const iterator of `std::vector<int>` has `value_type` int.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
