gemini-code-assist[bot] commented on code in PR #214: URL: https://github.com/apache/tvm-ffi/pull/214#discussion_r2482940708
########## addons/torch_c_dlpack_ext/README.md: ########## @@ -0,0 +1,26 @@ +<!--- Licensed to the Apache Software Foundation (ASF) under one --> +<!--- or more contributor license agreements. See the NOTICE file --> +<!--- distributed with this work for additional information --> +<!--- regarding copyright ownership. The ASF licenses this file --> +<!--- to you under the Apache License, Version 2.0 (the --> +<!--- "License"); you may not use this file except in compliance --> +<!--- with the License. You may obtain a copy of the License at --> + +<!--- http://www.apache.org/licenses/LICENSE-2.0 --> + +<!--- Unless required by applicable law or agreed to in writing, --> +<!--- software distributed under the License is distributed on an --> +<!--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY --> +<!--- KIND, either express or implied. See the License for the --> +<!--- specific language governing permissions and limitations --> +<!--- under the License. --> +# torch c dlpack extension Review Comment:  For better readability and to follow standard Markdown heading conventions, it's recommended to use title case for the main heading. Also, "DLPack" is usually written with this capitalization. ```suggestion # Torch C DLPack Extension ``` ########## addons/torch_c_dlpack_ext/README.md: ########## @@ -0,0 +1,26 @@ +<!--- Licensed to the Apache Software Foundation (ASF) under one --> +<!--- or more contributor license agreements. See the NOTICE file --> +<!--- distributed with this work for additional information --> +<!--- regarding copyright ownership. The ASF licenses this file --> +<!--- to you under the Apache License, Version 2.0 (the --> +<!--- "License"); you may not use this file except in compliance --> +<!--- with the License. You may obtain a copy of the License at --> + +<!--- http://www.apache.org/licenses/LICENSE-2.0 --> + +<!--- Unless required by applicable law or agreed to in writing, --> +<!--- software distributed under the License is distributed on an --> +<!--- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY --> +<!--- KIND, either express or implied. See the License for the --> +<!--- specific language governing permissions and limitations --> +<!--- under the License. --> +# torch c dlpack extension + +This folder contains an AOT wheel to build an optional module to support faster DLPack conversion. +We likely do not need this module after the latest PyTorch lands DLPack 1.2 support. +By default tvm-ffi will also JIT compile a version during loading. +It can be helpful for users to install this wheel to avoid the need to JIT the patching module. Review Comment:  This paragraph could be rephrased for improved clarity and accuracy. The current wording is slightly confusing (e.g., "contains an AOT wheel") and informal. Consider the following suggestion for a more precise and professional explanation. ```suggestion This folder contains the source for the `torch-c-dlpack-ext` package, which provides an Ahead-Of-Time (AOT) compiled module to support faster DLPack conversion. This module will likely become unnecessary once PyTorch releases include DLPack v1.2 support. By default, `tvm-ffi` will JIT-compile a version of this functionality during loading. Installing this wheel allows users to avoid this JIT compilation overhead. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
