gemini-code-assist[bot] commented on code in PR #212:
URL: https://github.com/apache/tvm-ffi/pull/212#discussion_r2480507257


##########
python/tvm_ffi/registry.py:
##########
@@ -29,7 +29,10 @@
 _SKIP_UNKNOWN_OBJECTS = False
 
 
-def register_object(type_key: str | type | None = None) -> Callable[[type], 
type] | type:
+_T = TypeVar('_T', bound=type)

Review Comment:
   ![critical](https://www.gstatic.com/codereviewagent/critical.svg)
   
   `TypeVar` is used here, but it has not been imported from the `typing` 
module. This will lead to a `NameError` when the module is imported.
   
   Please add it to the imports at the top of the file. For example, you can 
modify line 23 to:
   ```python
   from typing import Any, Callable, Literal, overload, TypeVar
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to