gemini-code-assist[bot] commented on code in PR #210:
URL: https://github.com/apache/tvm-ffi/pull/210#discussion_r2479511316
##########
python/tvm_ffi/utils/_build_optional_torch_c_dlpack.py:
##########
@@ -781,13 +782,13 @@ def main() -> None: # noqa: PLR0912, PLR0915
for python_libdir in python_libdir_list:
if python_libdir and (Path(python_libdir) /
python_lib).exists():
ldflags.append(f"/LIBPATH:{python_libdir.replace(':',
'$:')}")
- ldflags.append(python_lib)
break
Review Comment:
Instead of commenting out this line, it's better to remove it completely.
This improves code clarity and prevents confusion for future developers who
might wonder why it was left in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
