yaoyaoding commented on code in PR #206:
URL: https://github.com/apache/tvm-ffi/pull/206#discussion_r2476510534


##########
python/tvm_ffi/utils/lockfile.py:
##########
@@ -35,6 +35,19 @@ class FileLock:
 
     This class implements an advisory lock, which must be respected by all
     cooperating processes.
+

Review Comment:
   The only reason is to reduce the 3rdparty dependency (cc @tqchen). If the 
community think the filelock package is ok to have, there is no blocker for us 
to switch to it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to