yzh119 commented on code in PR #209:
URL: https://github.com/apache/tvm-ffi/pull/209#discussion_r2476385246
##########
docs/guides/cpp_guide.md:
##########
@@ -582,3 +582,74 @@ void ExampleVariant() {
```
Under the hood, Variant is a wrapper around Any that restricts the type to the
specific types in the list.
+
+## Distribution and ABI Compatibility
Review Comment:
The main purpose of C++ Guide is to introduce the Stable ABI.
It's a good idea to have a tutorial to introduce the distribution, maybe
creating a new user guide (where we can introduce how to distribute a `.so`
compiled from tvm-ffi and even how to distribute a python package upon it)?
##########
CONTRIBUTING.md:
##########
@@ -31,6 +31,133 @@ pip install --no-build-isolation -e . -v
```
We recommend using the `--no-build-isolation` flag to ensure compatibility
with your existing environment.
+
+## Setting Up Pre-commit Hooks
Review Comment:
Can you separate this to a standalone PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
