tqchen commented on code in PR #203: URL: https://github.com/apache/tvm-ffi/pull/203#discussion_r2475040117
########## python/tvm_ffi/utils/_build_optional_torch_c_dlpack.py: ########## @@ -30,13 +30,6 @@ import torch.torch_version import torch.utils.cpp_extension Review Comment: also document at the top. # Important: to avoid cyclic dependency, we avoid import tvm_ffi names at top level -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
