tqchen commented on issue #201:
URL: https://github.com/apache/tvm-ffi/issues/201#issuecomment-3461511625

   Looking at PyTorch repo, seems AT_ERROR was deprecated in favor of 
TORCH_CHECK, which was also using `stream<<` under the hood.
   
   ```
   // A utility macro to make it easier to test for error conditions from user
   // input.  Like TORCH_INTERNAL_ASSERT, it supports an arbitrary number of 
extra
   // arguments (evaluated only on failure), which will be printed in the error
   // message using operator<< (e.g., you can pass any object which has
   // operator<< defined.  Most objects in PyTorch have these definitions!)
   ```
   
   We do provide a `TVM_FFI_CHECK(cond, ErrorType)` that offers similar 
feature. Given this situation, i think likely we should not provide in 
upstream. However, i think it should not be hard to ask agent to build 
something that is similar to AT_ERROR
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to