junrushao commented on code in PR #191: URL: https://github.com/apache/tvm-ffi/pull/191#discussion_r2463963818
########## docs/get_started/stable_c_abi.rst: ########## @@ -0,0 +1,189 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license agreements. See the NOTICE file +.. distributed with this work for additional information +.. regarding copyright ownership. The ASF licenses this file +.. to you under the Apache License, Version 2.0 (the +.. "License"); you may not use this file except in compliance +.. with the License. You may obtain a copy of the License at +.. +.. http://www.apache.org/licenses/LICENSE-2.0 +.. +.. Unless required by applicable law or agreed to in writing, +.. software distributed under the License is distributed on an +.. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +.. KIND, either express or implied. See the License for the +.. specific language governing permissions and limitations +.. under the License. + +Stable C ABI +============ + +TVM-FFI centers on a single key idea: Review Comment: I worry less about absolute technical precision, comparing to how much time it takes impatient readers to get the high-level idea right. More specifically in our case, as a “get started” tutorial, I’d prefer the wording starts gentle and zooming in gradually into details. In this case, introducing a very high-level key idea (with less noise around impl details) seems more reasonable approach overall to me. Therefore, I don’t like the idea of “common stable C ABI protocol for all” which is less comprehensible than “ok this is the key idea” -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
