Re: [PR] [CORE] Use new for singleton to prevent de-alloc order issues [tvm-ffi]

Sat, 18 Oct 2025 16:59:11 -0700 


gemini-code-assist[bot] commented on code in PR #133:
URL: https://github.com/apache/tvm-ffi/pull/133#discussion_r2433513117


##########
src/ffi/object.cc:
##########
@@ -306,8 +306,12 @@ class TypeTable {
   }
 
   static TypeTable* Global() {
-    static TypeTable inst;
-    return &inst;
+    // deliberately create a new instance via raw new
+    // to ensure table lives longe in case unloading

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   There is a small typo in this comment. "longe" should be "longer".
   
   ```suggestion
       // to ensure table lives longer in case unloading
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to