tqchen commented on code in PR #78:
URL: https://github.com/apache/tvm-ffi/pull/78#discussion_r2404464501
##########
src/ffi/extra/structural_equal.cc:
##########
@@ -255,7 +255,7 @@ class StructEqualHandler {
}
}
- bool CompareMap(Map<Any, Any> lhs, Map<Any, Any> rhs) {
+ bool CompareMap(const Map<Any, Any>& lhs, const Map<Any, Any>& rhs) {
Review Comment:
under this paticular context, non-const works ok and not worse than const
refer, mainly because caller always move into the content here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
