gemini-code-assist[bot] commented on code in PR #156: URL: https://github.com/apache/tvm-ffi/pull/156#discussion_r2437817682
########## python/tvm_ffi/_optional_torch_c_dlpack.py: ########## @@ -39,6 +39,12 @@ def load_torch_c_dlpack_extension() -> Any: + if hasattr(torch.Tensor, "__c_dlpack_exchange_api__"): + # skip loading the extension if the __c_dlpack_exchange_api__ + # attribute is already set so we don't have to do it in + # newer version of PyTorch + return None + Review Comment:  This block of code is placed incorrectly, leading to a couple of issues: 1. **`NameError`**: It attempts to use the `torch` module before it's imported (the import is on line 595), which will cause a runtime error. 2. **Misplaced Docstring**: The function's docstring is now just a string literal because it's no longer the first statement in the function body. To resolve this, the added logic should be moved inside the `try` block after `torch` is imported. Please remove this block and re-insert it in the correct location. Here's an example of how the `try` block should be structured: ```python try: # optionally import torch import torch # noqa: PLC0415 if hasattr(torch.Tensor, "__c_dlpack_exchange_api__"): return None from torch.utils import cpp_extension # noqa: PLC0415 # ... rest of the logic ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
