gemini-code-assist[bot] commented on code in PR #146: URL: https://github.com/apache/tvm-ffi/pull/146#discussion_r2436421114
########## pyproject.toml: ########## @@ -220,6 +220,16 @@ docstring-code-line-length = "dynamic" [tool.cibuildwheel] build-verbosity = 1 +manylinux-x86_64-image = "manylinux2014" +manylinux-i686-image = "manylinux2014" +manylinux-pypy_x86_64-image = "manylinux2014" +manylinux-aarch64-image = "manylinux2014" +manylinux-ppc64le-image = "manylinux2014" +manylinux-s390x-image = "manylinux2014" +manylinux-armv7l-image = "manylinux2014" +manylinux-riscv64-image = "manylinux2014" +manylinux-pypy_aarch64-image = "manylinux2014" +manylinux-pypy_i686-image = "manylinux2014" Review Comment:  These settings for various architectures appear to be redundant given the rest of the `cibuildwheel` configuration in this file. - The `[tool.cibuildwheel.linux].archs` is set to `["x86_64", "aarch64"]` (line 247), so only these architectures will be built on Linux. - The `build` setting (line 237) does not include any PyPy builds (e.g., `pp*`), so the `manylinux-pypy_*-image` settings are not used. To improve clarity and maintainability, we should only specify the images for the architectures that are actually being built. ```suggestion manylinux-x86_64-image = "manylinux2014" manylinux-aarch64-image = "manylinux2014" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
