tqchen commented on code in PR #36:
URL: https://github.com/apache/tvm-ffi/pull/36#discussion_r2403536230
##########
include/tvm/ffi/function_details.h:
##########
@@ -34,6 +34,8 @@
namespace tvm {
namespace ffi {
+// forward declaration
+class Function;
Review Comment:
Is forward delcaration still needed? likely not if we leverae the TObjectRef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
