gemini-code-assist[bot] commented on code in PR #84:
URL: https://github.com/apache/tvm-ffi/pull/84#discussion_r2396147813


##########
python/tvm_ffi/__init__.py:
##########
@@ -17,7 +17,7 @@
 """TVM FFI Python package."""
 
 # version
-__version__ = "0.1.0b13"
+__version__ = "0.1.0b14"

Review Comment:
   ![medium](https://www.gstatic.com/codereviewagent/medium-priority.svg)
   
   To avoid version inconsistencies between `pyproject.toml` and this file, you 
can dynamically read the version from the package metadata at runtime. This 
would make the `tests/lint/check_version.py` script redundant and ensure a 
single source of truth for the version number.
   
   Since your project requires Python >= 3.9, `importlib.metadata` is available 
for this purpose.
   
   The suggestion below uses an inline import to contain the change to this 
line. A cleaner long-term solution would be to add `from importlib import 
metadata` at the top of the file and simply use `__version__ = 
metadata.version('apache-tvm-ffi')` here.
   
   ```suggestion
   __version__ = 
__import__("importlib.metadata").metadata.version("apache-tvm-ffi")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to