tqchen commented on code in PR #29:
URL: https://github.com/apache/tvm-ffi/pull/29#discussion_r2363024647


##########
Dockerfile:
##########
@@ -0,0 +1,57 @@
+# syntax=docker/dockerfile:1
+
+# Using NVIDIA CUDA base image https://hub.docker.com/r/nvidia/cuda
+# Based on your host CUDA driver version, you may need to select an older CUDA 
base image.
+# See 
https://gitlab.com/nvidia/container-images/cuda/blob/master/doc/supported-tags.md
+FROM nvidia/cuda:12.6.3-devel-ubuntu22.04 
+
+ARG DEBIAN_FRONTEND=noninteractive
+
+# Install prerequisites for external repositories

Review Comment:
   let us move to `tests/docker/` subfolder given this is mainly used for dev 
purpose.
   
   



##########
Dockerfile:
##########
@@ -0,0 +1,57 @@
+# syntax=docker/dockerfile:1
+
+# Using NVIDIA CUDA base image https://hub.docker.com/r/nvidia/cuda

Review Comment:
   needs ASF header



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to