On Fri, May 08, 2009 at 12:16:35PM +0200, Sven Neumann wrote:
> index 6ad3a78..ae8c2c6 100644
> --- a/interfaces/IDirectFBFont/idirectfbfont_ft2.c
> +++ b/interfaces/IDirectFBFont/idirectfbfont_ft2.c
> @@ -680,23 +680,22 @@ Probe( IDirectFBFont_ProbeContext *ctx )
>
>
> static DFBResult
> -Construct( IDirectFBFont *thiz,
> +Construct( IDirectFBFont *thiz,
> ... )
> {
> - int i;
> - DFBResult ret;
> - CoreFont *font;
> - FT_Face face;
> - FT_Error err;
> - FT_Int load_flags = FT_LOAD_DEFAULT;
> - FT2ImplData *data;
> - bool disable_charmap = false;
> - bool disable_kerning = false;
> - bool load_mono = false;
> - u32 mask = 0;
> -
> - CoreDFB *core;
> - char *filename;
> + int i;
> + DFBResult ret;
> + CoreFont *font;
> + FT_Face face;
> + FT_Error err;
> + FT_Int load_flags = FT_LOAD_DEFAULT;
> + FT2ImplData *data;
> + bool disable_charmap = false;
> + bool disable_kerning = false;
> + bool load_mono = false;
> + u32 mask = 0;
> + CoreDFB *core;
> + char *filename;
> DFBFontDescription *desc;
I at least would prefer cosmetics as separate commits usually, since it
makes reading the real changes a lot easier. Of course there maybe be
cases when splitting some cosmetic bits out of a larger change is too
painful but this one at least looks easy enough to split.
I'll refrain from commenting on the actual meat of the patch since fonts
aren't really my thing.
--
Ville Syrjälä
[email protected]
http://www.sci.fi/~syrjala/
_______________________________________________
directfb-dev mailing list
[email protected]
http://mail.directfb.org/cgi-bin/mailman/listinfo/directfb-dev
