On Tue, Aug 28, 2018 at 9:49 PM, Lucas De Marchi <[email protected]> wrote: > On Tue, Aug 28, 2018 at 12:01 PM Daniel Vetter <[email protected]> wrote: >> >> This gives us neat little CI integration. No more "you have a >> different version of shellcheck" - we just pick the one everyone can >> run with docker. Also, no more "oops, forgot to run make check", that >> is, if we adopt a merge request based flow. >> >> Even without this this is useful, since if you do a fork and test >> there, gitlab CI will run stuff for you. Example: >> >> https://gitlab.freedesktop.org/danvet/maintainer-tools/blob/master/.gitlab-ci.yml >> >> Observe the awesome green checkmark in the top-left corner! >> >> v2: Use python3 (Lucas). And fix whitespace. >> >> v3: Go back to python2, on fedora the python3 packages have a -3 >> suffix. Don't ask. > > IMO the suffix is actually a sane thing... otherwise things expecting > python2 would break if they don't work with python3. > > Anyway, I still don't see what's broken when you switch to python3. > > $ python --version > Python 2.7.15 > $ python3 --version > Python 3.6.6 > $ pip list | grep sphinx > DEPRECATION: The default format will switch to columns in the future. > You can use --format=(legacy|columns) (or define a > format=(legacy|columns) in your pip.conf under the [list] section) to > disable this warning. > $ pip3 list | grep sphinx > DEPRECATION: The default format will switch to columns in the future. > You can use --format=(legacy|columns) (or define a > format=(legacy|columns) in your pip.conf under the [list] section) to > disable this warning. > sphinx-rtd-theme (0.3.1) > sphinxcontrib-websupport (1.0.1.dev20180209) > $ $ cat $(which sphinx-build)| head -n 1 > #!/usr/bin/python3 > > And make html continues to work for me...
Maybe I screwed up something, but this is easy to try out: - for the maintainer-tools repo. For playing around I've pushed all my patches there. - switch to python3 with a commit in your own personal repo (the CI runner will pick it up anywhere). I tried, didn't work. -Daniel >> >> Reviewed-by: Lucas De Marchi <[email protected]> >> Signed-off-by: Daniel Vetter <[email protected]> >> --- >> .gitlab-ci.yml | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> create mode 100644 .gitlab-ci.yml >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml >> new file mode 100644 >> index 000000000000..9050d3eaf4e8 >> --- /dev/null >> +++ b/.gitlab-ci.yml >> @@ -0,0 +1,9 @@ >> +image: fedora:latest >> + >> +before_script: >> + - dnf install -y ShellCheck python2-docutils python2-sphinx make >> + >> +check: >> + stage: build >> + script: >> + - make check >> -- >> 2.18.0 >> >> _______________________________________________ >> dim-tools mailing list >> [email protected] >> https://lists.freedesktop.org/mailman/listinfo/dim-tools > > > > -- > Lucas De Marchi -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dim-tools mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dim-tools
