On Fri, Apr 27, 2001 at 03:43:28PM -0500, Steven Hazel wrote:

> "Kalle A. Sandstr\"om" <ksandstr at iki.fi> writes:
> 
> > Hm.  I'll look into it.  I think that libfreenet requires some cleaning
> > up, though... (frex, you're using floats to handle major.minor version
> > number pairs. ick.)
> 
> Yeah, it definitely does need some clean-up.  I've got an enormous
> list, and I'm working on it.

Is that a long list of small things or a small list of large things?-)

Anyway, mind passing the list my way?  Maybe I could fix some of the
things while fleshing out the libfreenet integration.

> > Also, I'm not quite happy with some of the exported symbol names in
> > libfreenet, but I'm sure that can be remedied somehow :-)
> 
> What don't you like?  API criticisms are highly appreciated.

Many functions aren't prefixed (inappropriate for a potentially shared
library).  The "freenet_get_connection" fn is too one-shot (a proper
node would have a thread run an accept(2) loop and pass the connected
socket fds to a peer handler).  I'm sure there are others too :-)

> > If you don't have anything in particular against glib-1.2, perhaps
> > we could migrate some of the better bits in reiska to libfreenet?
> 
> What do you gain by using glib-1.2?  I don't know if I want to have
> the dependency.

Reply via email to