We added QT_TECH_PREVIEW_API to 6.7 after 6.7.0 (because the tag wasn’t available in time for 6.7.0) so that we can see that difference when we remove it against from 6.8 (with the intention of informing reviewers about that change), and that’s now completely invisible.
Also header changes in 6.7 might be fixes (such as https://codereview.qt-project.org/c/qt/qtbase/+/565633, which shouldn’t have shown as a diff here). In short, I think we should review the delta between current 6.8 and current 6.7 (or at most latest 6.7 patch release), not 6.7.0. If we think that we should formally review changes within 6.7 patch cycles (ref discussion about permitting forward BiC breakage), then we should not abuse the 6.8 header review, IMHO. The change analyser tags changes in headers that get cherry-pick’ed with "API change cherry-picked”, so https://codereview.qt-project.org/q/hashtag:%22api+change+cherry-picked%22+status:merged lists all those. Cheers, Volker > On 10 Jun 2024, at 07:28, Jani Heikkinen <jani.heikki...@qt.io> wrote: > > Hi! > > I think the reason for this is that v6.7.0 is the API which is reviewed last > time. Using it as a base ensures that API changes in 6.7.x release will be > reviewed as well > > br, > Jani > >> -----Original Message----- >> From: Volker Hilsheimer <volker.hilshei...@qt.io> >> Sent: perjantai 7. kesäkuuta 2024 17.13 >> To: Jani Heikkinen <jani.heikki...@qt.io> >> Cc: development@qt-project.org >> Subject: Re: [Development] HEADS-UP: Qt 6.8 API change review >> >>> >>> On 4 Jun 2024, at 09:29, Jani Heikkinen via Development <development@qt- >> project.org> wrote: >>> >>> Hi! >>> Qt 6.8 API Change Review is started, see >> https://bugreports.qt.io/browse/QTBUG-125859 >>> generated diffs are here: >>> • https://codereview.qt-project.org/q/topic:api-change-review-6.8 >>> • https://codereview.qt-project.org/q/topic:qml_api_review_6.8 >>> Please review the diffs as soon as possible. >>> br, >>> Jani >> >> >> Is there a good reason for comparing 6.7.0 to 6.8, rather than 6.7 to 6.8? I >> see a >> few differences that shouldn’t be there (or should be … different), because >> the >> respective patch have also been cherry-picked to 6.7. E.g. qtmultimedia >> fixes to >> the BiC bug. >> >> >> Volker >> > -- Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
