On 15 Apr 2024, at 12:07, Daniel Smith via Development
<development@qt-project.org> wrote:
I'd like to open up a thread for discussion on the addition of a new commit
message footer, "Reopens", related to Fixes/Task-Number.
The proposed behaviour is:
*
Use of "Reopens: QTBUG1234" would trigger automatic reopening of the specified
jira issue upon uploading a new change to codereview.
*
Jira issues specifying Reopens would be tagged with the merged sha of the
change.
*
Issues specifying Reopens can be automatically closed by also specifying
"Fixes" as usual.
*
The Jira Closer Bot has traditionally refused to close issues which is has
previously closed. Including Reopens would bypass this check and allow the
issue to be closed with the presence of Fixes.
Is this really such an often occurrence that we need a keyword for it? If you
know that it invalidates a fix for an existing QTBUG, re-opening manually seems
like a pretty small task.
For reverts of commits with “Fixes” in them it should be fine to re-open the
bug. And to close it again once a new commit lands with Fixes. The bot should
be able to tell by the “author” of the status change in JIRA if it’s okey to
re-close it, no?
Is the motivation here primarily to allow the bot to re-close the issue later
on, even for non-reverts changes? How about we just trust the “Fixes” in the
change, and close the issue, even if it was previously re-opened?
Cheers,
Tor Arne
Additionally, also proposed with this keyword addition is automatic detection
of reverts by the bot for jira issue tagging. The bot would search for jira
issues related to the revert by:
*
Any issues specified in any footers of the revert change should be tagged with
the merged commit of the revert.
*
Any issues specified in any footers by the original change (sha) being reverted
should be tagged with the merged commit of the revert.
Please respond by Friday, 19 April if you have comments or further suggestions
on this proposal.
--
Development mailing list
Development@qt-project.org<mailto:Development@qt-project.org>
https://lists.qt-project.org/listinfo/development
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
