Earlier this week I discussed https://bugreports.qt.io/browse/QTQAINFRA-4763 
with Eddy. He will look into it. At the very least it creates more but also 
more targetted review requests. Especially qtbase suffers from this. It should 
make the responsibility of the maintainers more obvious. Hopefully we can 
manage to get this for the 6.6 review round.

--
Alex


________________________________________
From: Development <development-boun...@qt-project.org> on behalf of Fabian 
Kosmale via Development <development@qt-project.org>
Sent: Tuesday, 2 May 2023 11:33
To: development@qt-project.org
Subject: Re: [Development] Header review process: follow-up on comments

Hi,

while gerrit _didn't_ have support for it, that changed in 3.7. It needs
to be manually enabled
(https://www.gerritcodereview.com/3.7.html#mention-user-support), but
maybe that would be a good way forward?

Fabian

On 02.05.23 11:00, Volker Hilsheimer via Development wrote:
> With Qt 6.5, it’s been a struggle to get people to respond and follow-up to 
> comments made during the header review process.
>
> Gerrit doesn’t really care about @user-style mentioning in comments, even 
> though is seems that some people assume that it does. Creating JIRA tickets 
> is the official way of doing it, but creating a ticket just to get someone’s 
> attention to input (which might or might not require a change) seems 
> heavy-handed. Ultimately, lots of people will be on cc or review of the 
> respective header-review gerrit change, so everything becomes everyone’s 
> problem.
>
> Maintainers have a special responsibility during header review, but esp with 
> qtbase that is also a lot of people.
>
> What can we do to make this a better process that doesn’t end up with changes 
> being made very late (with 6.5 we had some the day before the release 
> candidate, IIRC)?
>
> Volker
>

--
Fabian Kosmale
Manager R&D

The Qt Company GmbH
Erich-Thilo-Str. 10
D-12489 Berlin
fabian.kosm...@qt.io
+49 1638686070
--
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development
-- 
Development mailing list
Development@qt-project.org
https://lists.qt-project.org/listinfo/development

Reply via email to