On Sat, Jun 08, 2019 at 10:39:09PM +0300, Konstantin Tokarev wrote: > > What about https://valdyas.org/fading/hacking/happy-porting/ > > > > "[...] none, not a single one of all of the reasons you want to > > deprecate Q_FOREACH is a reason I care even a little bit about. > > It’s going to be deprecated? Well, that’s a decision, and a dumb > > one. It doesn’t work on std containers, QVarLengthArray or C > > arrays? I don’t use it on those. It adds 100 bytes of text size? > > Piffle. It makes it hard to reason about the loop for you? I > > don’t care. > > > > What I do care is the 1559 places where we use Q_FOREACH in > > Krita. Porting this will take weeks. [...]" > > > > ? > > This kind of porting could be automated with clang-based tool, if > anyone cared to make it. This tool could automatically use > qAsConst/std::as_const for non-const lvalues and add temporary > variable for non-const rvalues, without user even knowing what the > hell are lvalues and rvalues and other things Marc writes about.
The discussion would me much less heated if the people deprecating would take care of the cleaning up. Creating a tool that would take care of it would be close to perfect in my book. Andre' _______________________________________________ Development mailing list Development@qt-project.org https://lists.qt-project.org/listinfo/development
