On 12/11/2018 23:03, Allan Sandfeld Jensen wrote: > On Montag, 12. November 2018 22:49:02 CET Thiago Macieira wrote: >> On Monday, 12 November 2018 12:38:38 PST Liang Qi wrote: >>> * 10:53am staged 8 changes togehter - >>> http://coin/coin/integration/qt/qtbase/tasks/1543764990 (failed in 53m - >>> tst_QEventDispatcher::registerTimer() on macOS 10.13) >> Thanks for all your effort, Liang. It is much appreciated. >> >> The above test seems flaky, but increasing the timeout doesn't help. It >> complains that 20 ms wasn't enough, but 20 ms would have been enough. When I >> increased to 50 ms, it prints the same thing but saying 50 ms. There are >> two more failures in the same test. >> >> So I'm inclined to believe that this is a real failure caused by something >> changing in the event dispatcher code relating to macOS. But the weird thing >> is that it should be running the QEventDispatcherUNIX class... > I would argue the test should be blacklisted at least on macOS 10.13 as a P0 > task. Fixing it can wait. > > 'Allan The test also fails on WinRT and thus at least the registerTimer test in corelib/kernel/qeventdispatcher is blacklisted for this platform. That one used to be blacklisted on macos as well, but is considered stable with 5.12. I think blacklisting registerTimer for the gui eventdispatcher on WinRT would make sense, as both tests use the same event dispatcher on this platform (I think that's also the case on Windows).
I had a look at the problem when I blacklisted it for WinRT and one problem was, that QTRY_IMPL used a hard coded step interval of 50 ms, which of course does not make sense if you try to have a timeout of 25 ms. In addition to that I don't know, how well coin copes with such short timeout, as VMs tend to be quite slow when run from Coin (in my experience). To sum things up, I think tests that are blacklisted for windows/winrt in tst_qeventdispatcher should at also be blacklisted in tst_qguieventdispatcher as the same event dispatcher is used (https://codereview.qt-project.org/245347). I don't know enough about Mac's approach, but tst_qeventdispatcher::registerTimer was unblacklisted recently as far as I know. Olli > > > _______________________________________________ > Development mailing list > Development@qt-project.org > http://lists.qt-project.org/mailman/listinfo/development _______________________________________________ Development mailing list Development@qt-project.org http://lists.qt-project.org/mailman/listinfo/development
