Hi
No, still getting same error.
The .moc generated file is the same, so or this not solve the issue, or
something is fishy on my environment.
I'm doing a full clean build by hand with your patch to dobcle check right
now, but as concerned on my current status, still a nope.
Here's the moc compile line that resulting the attached file:
kcoreaddons 1 /opt/qt5/bin/moc
-I/code/kde/build-kde/frameworks/kcoreaddons/autotests
-I/code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include
-I/code/kde/build-kde/frameworks/kcoreaddons/src/lib/../..
-I/code/kde/build-kde/frameworks/kcoreaddons/src/lib/io
-I/code/kde/build-kde/frameworks/kcoreaddons/src/lib
-I/code/kde/src/frameworks/kcoreaddons/autotests
-I/code/kde/src/frameworks/kcoreaddons/src/lib/caching
-I/code/kde/src/frameworks/kcoreaddons/src/lib/io
-I/code/kde/src/frameworks/kcoreaddons/src/lib/jobs
-I/code/kde/src/frameworks/kcoreaddons/src/lib/plugin
-I/code/kde/src/frameworks/kcoreaddons/src/lib/randomness
-I/code/kde/src/frameworks/kcoreaddons/src/lib/text
-I/code/kde/src/frameworks/kcoreaddons/src/lib/util
-I/code/kde/src/frameworks/kcoreaddons/src/lib -I/opt/qt5/include
-I/opt/qt5/include/QtCore -I/opt/qt5/./mkspecs/linux-clang
"-DKDELIBS4CONFIGMIGRATOR_DATA_DIR=\"/code/kde/src/frameworks/kcoreaddons/autotests/data\""
-DQT_CORE_LIB -DQT_NO_CAST_FROM_ASCII -DQT_NO_CAST_FROM_BYTEARRAY
-DQT_NO_CAST_TO_ASCII -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT
-DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING
-DQT_USE_QSTRINGBUILDER -D_GNU_SOURCE -D_LARGEFILE64_SOURCE --include
/code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/moc_predefs.h
-o
/code/kde/build-kde/frameworks/kcoreaddons/autotests/jsonplugin2_autogen/include/jsonplugin2.moc
/code/kde/src/frameworks/kcoreaddons/autotests/jsonplugin2.cpp
[]'s
On Wed, 5 Sep 2018 at 19:05, Thiago Macieira <[email protected]>
wrote:
> On Wednesday, 5 September 2018 09:57:30 PDT Thiago Macieira wrote:
> > On Wednesday, 5 September 2018 00:20:22 PDT Helio Chissini de Castro
> wrote:
> > > jsonplugin2.moc:153:1: error: narrowing conversion of ‘'\37777777703'’
> > > from ‘char’ to ‘unsigned char’ inside { } [-Wnarrowing]
> > > };
> >
> > [cut]
> >
> > > lude/jsonplugin2.moc:123:48: error: constant expression evaluates to
> -61
> > > which cannot be narrowed to type 'unsigned char'
> [-Wc++11-narrowing]
> > > ']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3',
> > > ^~~~~~
> >
> > I guess I didn't test non-ASCII content.
> >
> > moc was changed recently to save data in CBOR format instead of our
> binary
> > JSON.
>
> Please test this fix:
> https://codereview.qt-project.org/238950
>
> --
> Thiago Macieira - thiago.macieira (AT) intel.com
> Software Architect - Intel Open Source Technology Center
>
>
>
> _______________________________________________
> Development mailing list
> [email protected]
> http://lists.qt-project.org/mailman/listinfo/development
>
/****************************************************************************
** Meta object code from reading C++ file 'jsonplugin2.cpp'
**
** Created by: The Qt Meta Object Compiler version 67 (Qt 5.12.0)
**
** WARNING! All changes made in this file will be lost!
*****************************************************************************/
#include <QtCore/qbytearray.h>
#include <QtCore/qmetatype.h>
#include <QtCore/qplugin.h>
#if !defined(Q_MOC_OUTPUT_REVISION)
#error "The header file 'jsonplugin2.cpp' doesn't include <QObject>."
#elif Q_MOC_OUTPUT_REVISION != 67
#error "This file was generated using the moc from 5.12.0. It"
#error "cannot be used with the include files from this version of Qt."
#error "(The moc has changed too much.)"
#endif
QT_BEGIN_MOC_NAMESPACE
QT_WARNING_PUSH
QT_WARNING_DISABLE_DEPRECATED
struct qt_meta_stringdata_jsonplugin2_t {
QByteArrayData data[1];
char stringdata0[12];
};
#define QT_MOC_LITERAL(idx, ofs, len) \
Q_STATIC_BYTE_ARRAY_DATA_HEADER_INITIALIZER_WITH_OFFSET(len, \
qptrdiff(offsetof(qt_meta_stringdata_jsonplugin2_t, stringdata0) + ofs \
- idx * sizeof(QByteArrayData)) \
)
static const qt_meta_stringdata_jsonplugin2_t qt_meta_stringdata_jsonplugin2 = {
{
QT_MOC_LITERAL(0, 0, 11) // "jsonplugin2"
},
"jsonplugin2"
};
#undef QT_MOC_LITERAL
static const uint qt_meta_data_jsonplugin2[] = {
// content:
8, // revision
0, // classname
0, 0, // classinfo
0, 0, // methods
0, 0, // properties
0, 0, // enums/sets
0, 0, // constructors
0, // flags
0, // signalCount
0 // eod
};
void jsonplugin2::qt_static_metacall(QObject *_o, QMetaObject::Call _c, int _id, void **_a)
{
Q_UNUSED(_o);
Q_UNUSED(_id);
Q_UNUSED(_c);
Q_UNUSED(_a);
}
QT_INIT_METAOBJECT const QMetaObject jsonplugin2::staticMetaObject = { {
&KPluginFactory::staticMetaObject,
qt_meta_stringdata_jsonplugin2.data,
qt_meta_data_jsonplugin2,
qt_static_metacall,
nullptr,
nullptr
} };
const QMetaObject *jsonplugin2::metaObject() const
{
return QObject::d_ptr->metaObject ? QObject::d_ptr->dynamicMetaObject() : &staticMetaObject;
}
void *jsonplugin2::qt_metacast(const char *_clname)
{
if (!_clname) return nullptr;
if (!strcmp(_clname, qt_meta_stringdata_jsonplugin2.stringdata0))
return static_cast<void*>(this);
if (!strcmp(_clname, "org.kde.KPluginFactory"))
return static_cast< KPluginFactory*>(this);
return KPluginFactory::qt_metacast(_clname);
}
int jsonplugin2::qt_metacall(QMetaObject::Call _c, int _id, void **_a)
{
_id = KPluginFactory::qt_metacall(_c, _id, _a);
return _id;
}
QT_PLUGIN_METADATA_SECTION
static constexpr unsigned char qt_pluginMetaData[] = {
'Q', 'T', 'M', 'E', 'T', 'A', 'D', 'A', 'T', 'A', ' ', '!',
// metadata version, Qt version, architectural requirements
0, QT_VERSION_MAJOR, QT_VERSION_MINOR, qPluginArchRequirements(),
0xbf,
// "IID"
0x02, 0x76, 'o', 'r', 'g', '.', 'k', 'd',
'e', '.', 'K', 'P', 'l', 'u', 'g', 'i',
'n', 'F', 'a', 'c', 't', 'o', 'r', 'y',
// "className"
0x03, 0x6b, 'j', 's', 'o', 'n', 'p', 'l',
'u', 'g', 'i', 'n', '2',
// "MetaData"
0x04, 0xa1, 0x67, 'K', 'P', 'l', 'u', 'g',
'i', 'n', 0xa8, 0x6b, 'D', 'e', 's', 'c',
'r', 'i', 'p', 't', 'i', 'o', 'n', 0x76,
'T', 'h', 'i', 's', ' ', 'i', 's', ' ',
'a', 'n', 'o', 't', 'h', 'e', 'r', ' ',
'p', 'l', 'u', 'g', 'i', 'n', 0x6f, 'D',
'e', 's', 'c', 'r', 'i', 'p', 't', 'i',
'o', 'n', '[', 'n', 'l', ']', 0x78, 0x19,
'D', 'i', 't', ' ', 'i', 's', ' ', 'e',
'e', 'n', ' ', 'a', 'n', 'd', 'e', 'r',
'e', ' ', 'p', 'l', 'u', 'g', '-', 'i',
'n', 0x6f, 'D', 'e', 's', 'c', 'r', 'i',
'p', 't', 'i', 'o', 'n', '[', 'p', 't',
']', 0x76, 'E', 's', 't', 'e', ' ', '\xc3',
'\xa9', ' ', 'o', 'u', 't', 'r', 'o', ' ',
'\'', 'p', 'l', 'u', 'g', 'i', 'n', '\'',
0x72, 'D', 'e', 's', 'c', 'r', 'i', 'p',
't', 'i', 'o', 'n', '[', 'p', 't', '_',
'B', 'R', ']', 0x74, 'I', 's', 't', 'o',
' ', '\xc3', '\xa9', ' ', 'o', 'u', 't', 'r',
'o', ' ', 'p', 'l', 'u', 'g', 'i', 'n',
0x6f, 'D', 'e', 's', 'c', 'r', 'i', 'p',
't', 'i', 'o', 'n', '[', 's', 'v', ']',
0x78, 0x26, 'D', 'e', 't', ' ', 'h', '\xc3',
'\xa4', 'r', ' ', '\xc3', '\xa4', 'r', ' ', '\xc3',
'\xa4', 'n', 'n', 'u', ' ', 'e', 't', 't',
' ', 'i', 'n', 's', 't', 'i', 'c', 'k',
's', 'p', 'r', 'o', 'g', 'r', 'a', 'm',
0x6f, 'D', 'e', 's', 'c', 'r', 'i', 'p',
't', 'i', 'o', 'n', '[', 'u', 'k', ']',
0x78, 0x1e, '\xd0', '\xa6', '\xd0', '\xb5', ' ', '\xd1',
'\x96', '\xd0', '\xbd', '\xd1', '\x88', '\xd0', '\xb8', '\xd0',
'\xb9', ' ', '\xd0', '\xb4', '\xd0', '\xbe', '\xd0', '\xb4',
'\xd0', '\xb0', '\xd1', '\x82', '\xd0', '\xbe', '\xd0', '\xba',
0x73, 'D', 'e', 's', 'c', 'r', 'i', 'p',
't', 'i', 'o', 'n', '[', 'x', '-', 't',
'e', 's', 't', ']', 0x78, 0x1a, 'x', 'x',
'T', 'h', 'i', 's', ' ', 'i', 's', ' ',
'a', 'n', 'o', 't', 'h', 'e', 'r', ' ',
'p', 'l', 'u', 'g', 'i', 'n', 'x', 'x',
0x62, 'I', 'd', 0x66, 'f', 'o', 'o', 'b',
'a', 'r',
0xff,
};
QT_MOC_EXPORT_PLUGIN(jsonplugin2, jsonplugin2)
QT_WARNING_POP
QT_END_MOC_NAMESPACE
_______________________________________________
Development mailing list
[email protected]
http://lists.qt-project.org/mailman/listinfo/development
