30.03.2016, 00:53, "René J.V. Bertin" <[email protected]>: > Hi, > > I've got a few things I'd like to put up for code review, which I've been > putting off because I can only think of doing them either one by one > (carrying each to completion before moving on to the next) or by using > parallel working copies. Neither is what I'd call efficient, and I'm sure > there must be a more clever way to achieve the same thing, possible involving > git branches for instance. > > Can someone point me in the right direction, maybe to a tutorial of sorts > that outlines how to do several code reviews from a single working copy? > > I'm not exactly familiar with using branches; I just tried to create one, > apply a patch, commit it and then push to gerrit. > That was a bit of a failure; the commit to my local branch was also applied > to the branch I thought I'd branched off, and the push to gerrit was refused: > > %> git push gerrit > fatal: You are pushing to remote 'gerrit', which is not the upstream of > your current branch '5.6.0', without telling me what to push > to update which remote branch. > Exit 128 > > %> git push gerrit 5.6.0:5.6.0 > X11 forwarding request failed on channel 0 > Counting objects: 6, done. > Delta compression using up to 4 threads. > Compressing objects: 100% (6/6), done. > Writing objects: 100% (6/6), 820 bytes | 0 bytes/s, done. > Total 6 (delta 5), reused 0 (delta 0) > remote: Resolving deltas: 100% (5/5) > remote: Processing changes: refs: 1, done > To ssh://codereview.qt-project.org/qt/qtbase > ! [remote rejected] 5.6.0 -> 5.6.0 (prohibited by Gerrit) > error: failed to push some refs to 'ssh://codereview.qt-project.org/qt/qtbase' > Exit 1 > > Gerrit really ought to accept patches without requiring them to be committed > first; that should also make it much easier to keep them up to date to follow > evolution of the targeted code (in any case I don't see how it could not make > that easier).
https://wiki.qt.io/Gerrit_Introduction#Creating_and_Uploading_Contributions You were trying to make direct push to 5.6.0 (which you are not allowed to do), instead of pushing it to review. -- Regards, Konstantin _______________________________________________ Development mailing list [email protected] http://lists.qt-project.org/mailman/listinfo/development
